Adding BCD and some fixable flaws #906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think it may be a different problem — because those images are not in-tree, because the source looks like, for example, this: <img alt="Test_Form.jpg" id="img1" class="internal default" src="/files/3710/Test_Form_2.jpg" style="width: 100%;">…where that …but instead it’s going to here: https://yari-demos.prod.mdn.mozit.cloud/files/3710/Test_Form_2.jpg So, alerting @mdn/core-yari-dev |
ericwbailey
approved these changes
Jan 4, 2021
|
Ok. Let's carry on the discussion with broken images in mdn/yari#2331 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In mdn/sprints#3436 (comment) we decided to add the BCD for
filterto thefilter-functionpages, so this PR does that and also fixes a couple of typos I spotted and the reported fixable flaws.The filter page has a bunch of missing jpgs: https://developer.mozilla.org/en-US/docs/Web/CSS/filter this PR does not make that situation better or worse.
I wondered if this is the same issue @sideshowbarker encountered here: mdn/yari#2300